Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed optional dependency should use the renamed name #5753

Closed
withoutboats opened this issue Jul 20, 2018 · 1 comment · Fixed by #5811
Closed

Renamed optional dependency should use the renamed name #5753

withoutboats opened this issue Jul 20, 2018 · 1 comment · Fixed by #5811
Labels
A-optional-dependencies Area: dependencies with optional=true

Comments

@withoutboats
Copy link
Contributor

Given a Cargo.toml dependency stated like this:

[dependencies.dalek]
package = "ed25519-dalek"
version = "0.7.0"
optional = true

I expected to be able to turn the dependency on with cargo build --features dalek. However, this does not work. cargo build --features ed25519-dalek does work.

I think we should be consistent here in treating the dependency name, not the package name, as the name of this optional dependency.
@withoutboats withoutboats added the A-optional-dependencies Area: dependencies with optional=true label Jul 20, 2018
@matklad matklad mentioned this issue Jul 20, 2018
Closed
4 tasks
@alexcrichton alexcrichton mentioned this issue Jul 26, 2018
Merged
@alexcrichton
Copy link
Member

I agree yeah that this should use the name dalek for the feature, and this should be fixed in #5811

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Jul 31, 2018
@alexcrichton
Use listed dependency name for feature names
5295cad 
This commit updates the implementation of renamed dependencies to use the listed
name of a dependency in Cargo.toml for the name of the associated feature,
rather than using the package name. This'll allow disambiguating between
different packages of the same name and was the intention all along!

Closes rust-lang#5753
@Nemo157 Nemo157 mentioned this issue Jul 31, 2018
Closed
bors added a commit that referenced this issue Jul 31, 2018
@bors
Auto merge of #5811 - alexcrichton:rename-crate-feature-names, r=ehuss
d9feff2 
Use listed dependency name for feature names

This commit updates the implementation of renamed dependencies to use the listed
name of a dependency in Cargo.toml for the name of the associated feature,
rather than using the package name. This'll allow disambiguating between
different packages of the same name and was the intention all along!

Closes #5753
@Nemo157 Nemo157 mentioned this issue Sep 2, 2018
Closed
@Arnavion Arnavion mentioned this issue Sep 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-optional-dependencies Area: dependencies with optional=true
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use listed dependency name for feature names alexcrichton/cargo
2 participants
@alexcrichton @withoutboats