Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pretty_env_logger? #6348

Closed
dwijnand opened this issue Nov 26, 2018 · 4 comments · Fixed by #6362
Closed

Switch to pretty_env_logger? #6348

dwijnand opened this issue Nov 26, 2018 · 4 comments · Fixed by #6362
Assignees
@dwijnand

Comments

@dwijnand
Copy link
Member

https://github.com/seanmonstar/pretty-env-logger is pretty. Anyone feel for or against switch to it?
@Eh2406
Copy link
Contributor

Eh2406 commented Nov 26, 2018

👍 from me, and I would be ok fixing #6189 at the same time.

@alexcrichton
Copy link
Member

I'm personally a fan of env_logger due to how minimal it is where this isn't really an oft-used feature of Cargo that we want to pay a lot for in terms of dependencies, compile time, code size, etc. Along those lines I think I'd personally prefer to stick with env_logger today, but I don't feel too strongly!

@dwijnand
Copy link
Member Author

@alexcrichton what if I feature flag it? My usecase is when debugging cargo in tree anyways 😄

@alexcrichton
Copy link
Member

Seems plausible to me!

@dwijnand dwijnand mentioned this issue Nov 30, 2018
Merged
@dwijnand dwijnand self-assigned this Nov 30, 2018
bors added a commit that referenced this issue Nov 30, 2018
@bors
Auto merge of #6362 - dwijnand:pretty_env_logger, r=alexcrichton
d27b47b 
Switch to pretty_env_logger, under --features pretty-env-logger

Fixes #6348
@epage epage mentioned this issue Mar 2, 2023
Merged
bors added a commit that referenced this issue Mar 3, 2023
@bors
Auto merge of #11796 - epage:deps, r=weihanglo
7b443fb 
chore: Update base64

This removes one of cargo's duplicate dependencies as found by #11761.

`base64` is a bit of a controversial crate right now.  It is going through large API changes, making it not as ergonomic for basic cases, which has ticked off a number of people.  I kept it for now because its elsewhere in our dependency tree.

Byron already updated `prodash` to use the latest `parking_lot`

Remaining duplicates
- `hex` is blocked on `crypto-hash` which seems to no longer be maintained
- `hashbrown` is blocked on `indexmap` (updated in master) and `imara-diff`
- `humantime`, `env_logger`, `hermit-abi` are present from the optional `pretty_env_logger` dependency (why are we using optional deps? #6348)
- `windows-sys` is held back by `schannel`, `tempfile`, and `mio`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to pretty_env_logger, under --features pretty-env-logger dwijnand/cargo
3 participants
@alexcrichton @dwijnand @Eh2406