Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing of cargo run --features a b has regressed #7418

Closed
alexcrichton opened this issue Sep 23, 2019 · 0 comments · Fixed by #7419
Closed

Parsing of cargo run --features a b has regressed #7418

alexcrichton opened this issue Sep 23, 2019 · 0 comments · Fixed by #7419

Comments

@alexcrichton
Copy link
Member

Given a package that has the feature a but not the feature b, I get:

$ cargo run --features a b
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/wut b`
Hello, world!
$ cargo +beta run --features a b
error: Package `wut v0.1.0 (/home/alex/code/wut)` does not have these features: `b`

$ cargo --version
cargo 1.37.0 (9edd08916 2019-08-02)
$ cargo +beta --version
cargo 1.38.0-beta (23ef9a4ef 2019-08-20)

I suspect this is an accidental regression from #7084
@alexcrichton alexcrichton mentioned this issue Sep 23, 2019
Merged
bors added a commit that referenced this issue Sep 24, 2019
@bors
Auto merge of #7419 - alexcrichton:fix-features-regression, r=ehuss
aa6b7e0 
Fix interpretation of `--features a b` on the CLI

Fixes an accidental regression from #7084 where `--features a b` was
erroneously mistinterpreted as `--features "a b"`.

Closes #7418
@bors bors closed this as completed in 1fa02e7 Sep 24, 2019
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Sep 24, 2019
@alexcrichton
Fix interpretation of --features a b on the CLI
f393130 
Fixes an accidental regression from rust-lang#7084 where `--features a b` was
erroneously mistinterpreted as `--features "a b"`.

Closes rust-lang#7418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix interpretation of --features a b on the CLI alexcrichton/cargo
1 participant
@alexcrichton