-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo clean -p
does not clean documentation
#8790
Comments
I think part of the problem is that the search index would be broken since it would contain references to the now missing package. |
🤷 that seems like a reasonable tradeoff if the user explicitly opted-in to removing the documentation. This isn't specific to the search index, there could also be links in the downstream docs that are now broken. |
Hello, because you may be busy, do not have time to do such simple things. |
I think it would probably be fine to support this. I still think it could be confusing since things like the index won't be updated, but I also don't expect this to be needed too often. |
@rustbot claim |
Currently the `-p` is ignored. This should help with any confusion about the interaction of different flags. rust-lang#8790 is tracking to fix this.
Currently the `-p` is ignored. This should help with any confusion about the interaction of different flags. rust-lang#8790 is tracking to fix this.
Currently the `-p` is ignored. This should help with any confusion about the interaction of different flags. rust-lang#8790 is tracking to fix this.
Error out if `cargo clean --doc` is mixed with `-p`. This changes `cargo clean --doc -p foo` to generate an error instead of ignoring the `-p` flag. There is still an outstanding issue #8790 tracking this. It *should* support `-p`, but until it is supported, I think cargo should tell you that the flag is ignored. This is also in preparation for some code changes in #12634 which needs to handle any combination of various different clean flags.
Problem
cargo clean -p package
should removetarget/doc/package
, but does not.Steps
Possible Solution(s)
Notes
Output of
cargo version
:cargo 1.47.0 (f3c7e06 2020-08-28), but the bug is also present in
cargo 1.48.0-nightly (9d1a4863a 2020-10-05)
.The text was updated successfully, but these errors were encountered: