Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute non custom build and non transitive deps for doc #10341

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Compute non custom build and non transitive deps for doc #10341

merged 2 commits into from
Feb 3, 2022

Conversation

Rustin170506
Copy link
Member

What does this PR try to resolve?

close #10318 and close #9198

How should we test and review this PR?

Compute non custom build and non transitive deps for doc.
Add test for it.

@Rustin170506
Copy link
Member Author

r? @ehuss

The robot doesn't seem to be working.
Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

ehuss
ehuss reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think since the code is now identical between both, can all of this filtering be moved to state.deps? Instead of passing in a callback, just inline the code where filter is called.

@Rustin170506
Copy link
Member Author

I think since the code is now identical between both, can all of this filtering be moved to state.deps? Instead of passing in a callback, just inline the code where filter is called.

Make sense. Addressed!

@ehuss
Copy link
Contributor

ehuss commented Feb 3, 2022

Thanks! There was once a reason why these two different code paths had different filters, but I cannot recall from the dusty recesses of my mind why that was. I've tried to think of any potential problems this might cause, but I'm unable to think of any scenario where it won't work.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2022

📌 Commit bd45ac8 has been approved by ehuss

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 3, 2022
@bors
Copy link
Contributor

bors commented Feb 3, 2022

⌛ Testing commit bd45ac8 with merge be4bb61...

@bors
Copy link
Contributor

bors commented Feb 3, 2022

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing be4bb61 to master...

@bors bors merged commit be4bb61 into rust-lang:master Feb 3, 2022
This was referenced Feb 3, 2022
Merged
Open
This was referenced Feb 8, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2022
@bors
Auto merge of rust-lang#93793 - ehuss:update-cargo, r=ehuss
e1f586c 
Update cargo

5 commits in 25fcb135d02ea897ce894b67ae021f48107d522b..c082648646cbb2be266df9ecbcdc253058158d68
2022-02-01 01:32:48 +0000 to 2022-02-08 14:55:05 +0000
- Add rustup link (rust-lang/cargo#10371)
- Improve startup time of bash completion. (rust-lang/cargo#10365)
- Stabilize `-Ztimings` as `--timings` (rust-lang/cargo#10245)
- Remove needless borrow (rust-lang/cargo#10360)
- Compute non custom build and non transitive deps for doc (rust-lang/cargo#10341)
@ehuss ehuss added this to the 1.60.0 milestone Feb 24, 2022
@DieracDelta DieracDelta mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss Awaiting requested review from ehuss

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.60.0
3 participants
@Rustin170506 @ehuss @bors