Made hidden features hidden on cargo add when not activated
#10878
Conversation
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
johnmatthiggins
changed the title
cargo add when not activated
There was a problem hiding this comment.
Thank you for your contribution!
Could you add some tests like the following?
https://github.com/rust-lang/cargo/tree/master/tests/testsuite/cargo_add
Here is the guide to adding UI tests: https://doc.crates.io/contrib/tests/writing.html#ui-tests
| shell.write_stderr(format_args!(" {}\n", feat), &ColorSpec::new())?; | ||
| let is_hidden = feat.chars().nth(0).map(|c| c == '_').unwrap_or(false); | ||
|
|
||
| if !is_hidden { |
There was a problem hiding this comment.
I know this wasn't in the Issue but how about we also show these features when the user has increased the verbosity? We could use config.extra_verbose for now. Might be good to lower that to just verbose at a later point but that'll require some more rework because it isn't directly exposed
There was a problem hiding this comment.
I think this is a cool idea and I would love to implement it. However, given the existence of issue #10882 and my inexperience with this project, I'm not sure how to proceed with this PR. Should I wait for the requirements to be clearer before making any more changes?
There was a problem hiding this comment.
I'd recommend holding off until a determination has been made about #10794.
To add, we should make sure we cover all cases, like when the hidden features are activated and deactivated. |
src/cargo/ops/cargo_add/mod.rs
Outdated
| shell.write_stderr(&prefix, &ColorSpec::new())?; | ||
| shell.write_stderr('-', &ColorSpec::new().set_bold(true).set_fg(Some(Red)))?; | ||
| shell.write_stderr(format_args!(" {}\n", feat), &ColorSpec::new())?; | ||
| let is_hidden = feat.chars().nth(0).map(|c| c == '_').unwrap_or(false); |
There was a problem hiding this comment.
This is hiding the feature if its deactivated. In the original issue, I mentioned also hiding the feature if its indirectly activated.
Thoughts?
johnmatthiggins
force-pushed
the
hide_hidden
branch
from
17faac4
to
3c4fa0b
Compare
weihanglo
removed
the
S-waiting-on-review
Fixes issue #10794.