Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta backport #11082 #11097

Merged
merged 9 commits into from
Sep 16, 2022
Merged

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Sep 16, 2022

This is only doc change. Cherry-picked #11082 from b5bcd47 to f39f8dc

r? @epage

In looking over rust-lang#10625, I remembered we've been having growing pains
with the workspace documentation.  It was originally written when there
were a lot fewer workspace features.  As more workspace features have
been added, they've been tacked on to the documentation.

This re-thinks the documentation by focusing on the schema, much like
`manifest.md` does.
This is a part of the schema we were missing.  A first step before
encouraging people to use it is to document it!
In a workspace, only the workspace's profile is respected.  This is
already documented in the profile documentation but we should raise
visibility of it within the workspace documentation.
The workspace behavior doesn't seem to be documented at all, so a blurb
was brought in that is like the profile blurb.  The workspace docs then
link out to it so users can be aware of this special workspace behavior.
This is a frequent reason I use them
@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.64.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2022
@epage
Copy link
Contributor

epage commented Sep 16, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 16, 2022

📌 Commit a1c48c5 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2022
@bors
Copy link
Contributor

bors commented Sep 16, 2022

⌛ Testing commit a1c48c5 with merge 387270b...

@bors
Copy link
Contributor

bors commented Sep 16, 2022

☀️ Test successful - checks-actions
Approved by: epage
Pushing 387270b to rust-1.64.0...

@bors bors merged commit 387270b into rust-lang:rust-1.64.0 Sep 16, 2022
weihanglo added a commit to weihanglo/rust that referenced this pull request Sep 16, 2022
3 commits in 4bcb3c65e440a12044092b85ffea8fac6cb96f42..387270bc7f446d17869c7f208207c73231d6a252
2022-08-17 21:01:34 +0000 to 2022-09-16 20:18:27 +0000

- Beta backport rust-lang/cargo#11082 (rust-lang/cargo#11097)
- [Beta] Run `reach_max_unpack_size` test only on debug build (rust-lang/cargo#11090)
- [beta] Fix for CVE-2022-36113 and CVE-2022-36114 (rust-lang/cargo#11088)
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2022
3 commits in 4bcb3c65e440a12044092b85ffea8fac6cb96f42..387270bc7f446d17869c7f208207c73231d6a252
2022-08-17 21:01:34 +0000 to 2022-09-16 20:18:27 +0000

- Beta backport rust-lang/cargo#11082 (rust-lang/cargo#11097)
- [Beta] Run `reach_max_unpack_size` test only on debug build (rust-lang/cargo#11090)
- [beta] Fix for CVE-2022-36113 and CVE-2022-36114 (rust-lang/cargo#11088)
@ehuss ehuss added this to the 1.64.0 milestone Sep 21, 2022
@weihanglo weihanglo deleted the beta-backport-workspace-doc branch September 21, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants