Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lingering unstable flag -Zfeatures #11168

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Remove lingering unstable flag -Zfeatures #11168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/cargo/core/features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,10 +931,13 @@ impl CliUnstable {
"host-config" => self.host_config = parse_empty(k, v)?,
"target-applies-to-host" => self.target_applies_to_host = parse_empty(k, v)?,
"features" => {
// For now this is still allowed (there are still some
// unstable options like "compare"). This should be removed at
// some point, and migrate to a new -Z flag for any future
// things.
// `-Z features` has been stabilized since 1.51,
// but `-Z features=compare` is still allowed for convenience
// to validate that the feature resolver resolves features
// in the same way as the dependency resolver,
// until we feel confident to remove entirely.
//
// See rust-lang/cargo#11168
let feats = parse_features(v);
let stab_is_not_empty = feats.iter().any(|feat| {
matches!(
Expand Down