Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Distinguish 'testname' from escaped arguments #11190

Merged
merged 2 commits into from
Oct 7, 2022
Merged

fix(test): Distinguish 'testname' from escaped arguments #11190

merged 2 commits into from
Oct 7, 2022

Commits on Oct 7, 2022

  1. test(test): Verify escaping behavior

    @epage
    epage committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    dd6228e View commit details
    Browse the repository at this point in the history

  2. fix(test): Distinguish 'testname' from escaped arguments 

    When working on clap v4, it appeared that `last` and `trailing_var_arg`
are mutually exclusive, so I called that out in the debug asserts in
clap-rs/clap#4187.  Unfortunately, I didn't document my research on this
as my focus was elsewhere.

When updating cargo to use clap v4 in rust-lang#11159, I found `last` and
`trailing_var_arg` were used together.  I figured this was what I was
trying to catch with above and I went off of my intuitive sense of these
commands and assumed `trailing_var_arg` was intended, not knowing about
the `testname` positional that is mostly just a forward to `libtest`,
there for documentation purposes, except for a small optimization.

So it looks like we just need the `last` call and not the
`trailing_var_arg` call.

This restores us to behavior from 531ce13 which is what I originally
wrote the tests against.
    @epage
    epage committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    3dd8413 View commit details
    Browse the repository at this point in the history