Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix split-debuginfo support detection #11347

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Fix split-debuginfo support detection #11347

merged 2 commits into from
Jan 26, 2023

Commits on Nov 8, 2022

  1. Fix split-debuginfo support detection 

    cargo assumed that if -Csplit-debuginfo=packed worked, all values would
be correct. This however is not the case -- as of Rust 1.65.0, rustc
supports packed, but not unpacked or off on Windows. Because of this,
having split-debuginfo="unpacked" on Windows has caused builds to fail,
as cargo assumed that the option is fine (split-debuginfo=packed
worked), but rustc then failed when being passed
-Csplit-debuginfo=unpacked.

This patch invokes rustc with the --print=split-debuginfo to query
supported values and ignores the Cargo.toml entry if not supported.
    @kamirr
    kamirr committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    856ed94 View commit details
    Browse the repository at this point in the history

  2. Extract logic to TargetInfo::supports_debuginfo_split

    @kamirr
    kamirr committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    fe95630 View commit details
    Browse the repository at this point in the history