Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output harness in cargo metadata #11847

Closed
wants to merge 1 commit into from

Conversation

jordanisaacs
Copy link

What does this PR try to resolve?

Adds harness to output of cargo metadata. Closes #11846 . Useful for third party rust build tools that want to use Cargo.toml metadata.

How should we test and review this PR?

Updated the metadata tests with the new harness output.

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 31, 2023

Thanks! It looks like there is a test failure, you'll need to run tests with nightly to check benchmarks.

Can you also update the documentation at https://github.com/rust-lang/cargo/blob/master/src/doc/man/cargo-metadata.md, and regenerate the man pages (documented at https://github.com/rust-lang/cargo/tree/master/src/doc#building-the-man-pages)? Also https://github.com/rust-lang/cargo/blob/master/src/doc/src/reference/external-tools.md looks to also need updating.

@ehuss ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2023
@weihanglo
Copy link
Member

Ping @jordanisaacs. Just checking in to see if you are still interested in working on this. As Eric mentioned in #11847 (comment), there are some doc updates needing to be done, and we're ready to go!

@ehuss
Copy link
Contributor

ehuss commented Dec 4, 2023

I'm going to close due to inactivity. If you are interested in continuing on this, feel free to reopen (just beware that due to a quirk in GitHub, if you push to your branch before reopening that you'll need to open a new PR instead).
Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manifest Area: Cargo.toml issues S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add harness field to cargo metadata output
5 participants