Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libc to 0.2.142 #12014

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Bump libc to 0.2.142 #12014

merged 1 commit into from
Apr 24, 2023

Conversation

ecnelises
Copy link
Contributor

@ecnelises ecnelises commented Apr 21, 2023

libc 0.2.141 cannot build successfully on AIX. (CI on AIX is not available yet)

Upgrade libc to 0.2.142 to make cargo build on AIX.

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2023
@weihanglo
Copy link
Member

Thanks for being interested in contributing to this project! However, it's difficult to make progress on a pull request lacking for a clear context. Contributors are encouraged to follow the process of submitting a PR in Cargo Contributor Guide, as well as the guideline in the pull request template.

A clear description also helps us to trace back in the future why this change was made, even when the change is quite simple as this one. Thank you!

@rustbot label +S-waiting-on-author

@rustbot rustbot added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Apr 21, 2023
@weihanglo weihanglo removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2023
@weihanglo

This comment was marked as off-topic.

@ecnelises
Copy link
Contributor Author

ecnelises commented Apr 23, 2023

Hi, libc 0.2.141 cannot build successfully on AIX. (CI on AIX is not available yet)

error[E0308]: mismatched types
   --> src/unix/aix/powerpc64.rs:202:9
    |
201 |     pub unsafe fn si_value(&self) -> ::sigval {
    |                                      -------- expected `unix::sigval` because of return type
202 |         self.si_value
    |         ^^^^^^^^^^^^^ expected `unix::sigval`, found `aix::powerpc64::sigval`
    |
    = note: `aix::powerpc64::sigval` and `unix::sigval` have similar names, but are actually distinct types
note: `aix::powerpc64::sigval` is defined in module `crate::unix::aix::powerpc64` of the current crate

This was fixed after 0.2.141 release. (rust-lang/libc@7a1d2c6 )

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Apr 23, 2023
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for the explanation and reference!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 24, 2023

📌 Commit b129076 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@bors
Copy link
Collaborator

bors commented Apr 24, 2023

⌛ Testing commit b129076 with merge c5bee5d...

@bors
Copy link
Collaborator

bors commented Apr 24, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing c5bee5d to master...

@bors bors merged commit c5bee5d into rust-lang:master Apr 24, 2023
@ecnelises
Copy link
Contributor Author

Thanks!

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
Update cargo

17 commits in de80432f04da61d98dcbbc1572598071718ccfd2..9e586fbd8b931494067144623b76c37d213b1ab6
2023-04-21 13:18:32 +0000 to 2023-04-25 22:09:11 +0000
- Update home dependency (rust-lang/cargo#12037)
- Warn instead of error in `cargo package` on empty `readme` or `license-file` in manifest (rust-lang/cargo#12036)
- Clarify documentation around test target setting. (rust-lang/cargo#12032)
- fix: apply `[env]` to target info discovery rustc (rust-lang/cargo#12029)
- CI: ensure intra links for all members are checked (rust-lang/cargo#12025)
- chore: make credential dependencies platform-specific (rust-lang/cargo#12027)
- CI: use `-p` to specify workspace members instead of `--manifest-path` (rust-lang/cargo#12024)
- ci: requires `test_gitoxide` and `lockfile` for both bors success and failure (rust-lang/cargo#12026)
- Update windows-sys (rust-lang/cargo#12021)
- Bump libc to 0.2.142 (rust-lang/cargo#12014)
- Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005)
- Improve error message for empty dep (rust-lang/cargo#12001)
- Remove wrong url in benchsuite manifest. (rust-lang/cargo#12020)
- Bump versions of local crates (rust-lang/cargo#12019)
- Add the Win32_System_Console feature since it is used (rust-lang/cargo#12016)
- Update outdated crates.io URLs in publishing guide (rust-lang/cargo#12018)
- Allow named debuginfo options in Cargo.toml (rust-lang/cargo#11958)

r? `@ghost`
@ehuss ehuss added this to the 1.71.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants