Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use pull request head commit whenever possible #12508

Merged
merged 1 commit into from
Aug 16, 2023
Merged

ci: use pull request head commit whenever possible #12508

merged 1 commit into from
Aug 16, 2023

Commits on Aug 15, 2023

  1. ci: use pull request head commit whenever possible 

    The `github.sha` is a merge commit with the parents of latest master
and the head of the pr. Trying to diff the changes from that merge
SHA to base will show all changes that have been made in-between.

And that doesn't seem about right.

We switch to `github.event.pull_request.head.sha` if there is a pr.

See: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/version-bump.20CI.20failing
    @weihanglo
    weihanglo committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4360d9d View commit details
    Browse the repository at this point in the history