Support public dependency configuration with workspace deps
#12817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the processing of `workspace = true` dependencies in the `[dependencies]` section to process the `public` field. Previously this field was ignored and didn't get plumbed through as configured.
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-manifest
|
👋 @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
btw your doing this finally pushed me over the edge to write a superseding Pre-RFC to avoid the problems that have kept this in limbo for 6 years. |
|
Oh awesome! I left a comment over there, and thanks! (sorry placed this on rust-lang/rust#44663 by accident so now I generate more notifications) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2023
Update cargo 17 commits in 6fa6fdc7606cfa664f9bee2fb33ee2ed904f4e88..ff768b45b302efd488178b31b35489e4fabb8799 2023-10-10 23:06:08 +0000 to 2023-10-17 12:51:31 +0000 - Clarify flag behavior in `cargo remove --help` (rust-lang/cargo#12823) - doc(cargo-login): mention args after `--` in manpage (rust-lang/cargo#12832) - changelog: add compat notice for `cargo login -- <arg>` (rust-lang/cargo#12830) - update SPDX License info (rust-lang/cargo#12827) - Add test for `-V` short argument (rust-lang/cargo#12822) - add detailed message when target folder path is invalid (rust-lang/cargo#12820) - chore(deps): update rust crate toml_edit to 0.20.2 (rust-lang/cargo#12761) - Support `public` dependency configuration with workspace deps (rust-lang/cargo#12817) - Update rustix to 0.38.18 (rust-lang/cargo#12815) - contrib docs: add some conveniences (rust-lang/cargo#12812) - Better suggestion for unsupported `--path` flag (rust-lang/cargo#12811) - contrib docs: update rfc and roadmap links (rust-lang/cargo#12814) - contrib doc: remove extraneous word (rust-lang/cargo#12813) - Update curl-sys to pull in curl 8.4.0 (rust-lang/cargo#12808) - feat: add package name and version to warning messages (rust-lang/cargo#12799) - Do not call it "Downgrading" when difference is only build metadata (rust-lang/cargo#12796) - Add unsupported short flag suggestion for `--target` and `--exclude` flags (rust-lang/cargo#12805) r? ghost
27 tasks
epage
added a commit
to epage/cargo
that referenced
this pull request
Dec 6, 2023
This is a step towards #44663. When discussing inheriting this field for rust-lang#13046, we realized that we should probably start by disallowing inheritance. We can always add it later. imo the principle of what should be inherited is what is truely common among dependencies. For example, we don't allow removing features. Public should not be universally applied and likely should be explicit so its not over-done, especially since we can't (atm) lint for when a public dependency could be non-public. This reverts parts of rust-lang#12817
epage
added a commit
to epage/cargo
that referenced
this pull request
Dec 6, 2023
This is a step towards #44663. When discussing inheriting this field for rust-lang#13046, we realized that we should probably start by disallowing inheritance. We can always add it later. imo the principle of what should be inherited is what is truely common among dependencies. For example, we don't allow removing features. Public should not be universally applied and likely should be explicit so its not over-done, especially since we can't (atm) lint for when a public dependency could be non-public. This reverts parts of rust-lang#12817
bors
added a commit
that referenced
this pull request
Dec 6, 2023
fix(toml): Disallow inheriting of dependency public status ### What does this PR try to resolve? This is a step towards rust-lang/rust#44663. When discussing inheriting this field for #13046, we realized that we should probably start by disallowing inheritance. We can always add it later. imo the principle of what should be inherited is what is truely common among dependencies. For example, we don't allow removing features. Public should not be universally applied and likely should be explicit so its not over-done, especially since we can't (atm) lint for when a public dependency could be non-public. ### How should we test and review this PR? ### Additional information This reverts parts of #12817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the processing of
workspace = truedependencies in the[dependencies]section to process thepublicfield. Previously this field was ignored and didn't get plumbed through as configured.Also 👋 it's been awhile!