Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enable m1 runner #13377

Merged
merged 1 commit into from
Jan 31, 2024
Merged

chore(ci): enable m1 runner #13377

merged 1 commit into from
Jan 31, 2024

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Enable M1 runner in Cargo's CI pipeline.

In the foreseeable future, aarch64-apple-darwin would be a tier-1 platform. Regardless, it is a major platform people use right now.

How should we test and review this PR?

Is there any other concern?

  • Should we pay attention to billing issue?
  • Reach out to t-infra?
  • Too small the machine is (7GB RAM right now)

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2024

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2024
@epage
Copy link
Contributor

epage commented Jan 31, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 31, 2024

📌 Commit b3ac10f has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2024
@bors
Copy link
Contributor

bors commented Jan 31, 2024

⌛ Testing commit b3ac10f with merge d170c0e...

bors added a commit that referenced this pull request Jan 31, 2024
@epage
Copy link
Contributor

epage commented Jan 31, 2024

@bors r-

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2024
@Muscraft
Copy link
Member

I was mistaken in in my comment here, which led to an r-, so I will r+ it again.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 31, 2024

📌 Commit b3ac10f has been approved by Muscraft

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jan 31, 2024
@bors
Copy link
Contributor

bors commented Jan 31, 2024

⌛ Testing commit b3ac10f with merge aa18926...

@bors
Copy link
Contributor

bors commented Jan 31, 2024

☀️ Test successful - checks-actions
Approved by: Muscraft
Pushing aa18926 to master...

@bors bors merged commit aa18926 into rust-lang:master Jan 31, 2024
21 checks passed
@weihanglo
Copy link
Member Author

The CI result shows that M1 runner is the fastest among all platforms, around ~12 mins. For comparsion, x86_64 Linux stable took 13 mins and x86_64 darwin took 40 mins.

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2024
Update cargo

24 commits in 7bb7b539558dc88bea44cee4168b6269bf8177b0..cdf84b69d0416c57ac9dc3459af80dfb4883d27a
2024-01-20 00:15:32 +0000 to 2024-02-02 19:39:16 +0000
- Apply `-Zpanic-abort-tests` to doctests too (rust-lang/cargo#13388)
- Don't print rustdoc command lines on failure by default (rust-lang/cargo#13387)
- Ensure `nonzero_exit_code` test isn't affected by developers `RUST_BACKTRACE` setting (rust-lang/cargo#13385)
- Add `docsrs` cfg as a well known `--check-cfg` (rust-lang/cargo#13383)
- fix(new): Print a note, rather than a comment, for more information (rust-lang/cargo#13371)
- Change tests to support changes to suggestion (rust-lang/cargo#13382)
- chore(ci): enable m1 runner (rust-lang/cargo#13377)
- fix(toml): Improve map/sequence error message (rust-lang/cargo#13376)
- fix(diagnostic): Don't panic on empty spans (rust-lang/cargo#13375)
- doc: Hide `cargo-fetch` description in offline man page (rust-lang/cargo#13364)
- feat: stabilize lockfile v4 (rust-lang/cargo#12852)
- fix(new): Print a 'Creating', rather than 'Created' status (rust-lang/cargo#13367)
- fix: use spec id instead of name to match package (rust-lang/cargo#13335)
- refactor(shell): Use new fancy anstyle API (rust-lang/cargo#13368)
- feat(cargo-update): `--precise` to allow yanked versions (rust-lang/cargo#13333)
- refactor: remove unnecessary Option in `Freshness::Dirty` (rust-lang/cargo#13361)
- doc: Replace version with `latest` for jobserver link (rust-lang/cargo#13366)
- test: data layout fix for `x86_64-unknown-none-gnu` (rust-lang/cargo#13362)
- docs(ref): Try to improve reg auth docs (rust-lang/cargo#13351)
- fix typo of rustbuild, instead of rustuild (rust-lang/cargo#13357)
- fix(config): Deprecate non-extension files (rust-lang/cargo#13349)
- fix(cli): Improve errors related to cargo script (rust-lang/cargo#13346)
- fix list option description starting with uppercase (rust-lang/cargo#13344)
- Fix typo in test (rust-lang/cargo#13342)
@rustbot rustbot added this to the 1.78.0 milestone Feb 5, 2024
@weihanglo weihanglo deleted the m1-runner branch February 21, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants