Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gate some libc usages under cfg(unix), drop os_info features #13782

Merged
merged 3 commits into from
Apr 23, 2024
Merged

gate some libc usages under cfg(unix), drop os_info features #13782

merged 3 commits into from
Apr 23, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Apr 19, 2024 •
edited
Loading

Places few libc usages under cfg(unix). That didn't remove it from tree, but still looks cleaner.
Drop features from os_info crate, as serde support currently unused.

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-credential-provider Area: credential provider for storing and retreiving credentials S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2024
@klensy klensy changed the title gate some libc usages under cfg(unix) gate some libc usages under cfg(unix), drop os_info features Apr 19, 2024
weihanglo
weihanglo reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct for usages in Cargo, though it doesn't really help shave off libc on Windows.

I am curious of what came to you for this, and also the benefit of it.

credential/cargo-credential/Cargo.toml Show resolved Hide resolved
@klensy
cargo-credential: bump version to 0.4.5
57e820e 
as required by check-version-bump CI
@klensy
Copy link
Contributor Author

klensy commented Apr 20, 2024

This looks correct for usages in Cargo, though it doesn't really help shave off libc on Windows.

I am curious of what came to you for this, and also the benefit of it.

Initially i wanted to chop unused deps from cargo: found some target dependent libc usages and disabled them (but there a lot of libc around, so no complete remove), work was done and i decided to commit it anyway.

@weihanglo
Copy link
Member

Thanks.

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 23, 2024

📌 Commit 57e820e has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2024
@bors
Copy link
Collaborator

bors commented Apr 23, 2024

⌛ Testing commit 57e820e with merge 125aa57...

@bors
Copy link
Collaborator

bors commented Apr 23, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 125aa57 to master...

@bors bors merged commit 125aa57 into rust-lang:master Apr 23, 2024
23 checks passed
@weihanglo weihanglo mentioned this pull request Apr 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@bors
Auto merge of rust-lang#124312 - weihanglo:update-cargo, r=weihanglo
c1feb3e 
Update cargo

7 commits in 80d5b607dde6ef97dfff4e23923822c01d2bb036..c9392675917adc2edab269eea27c222b5359c637
2024-04-19 18:39:22 +0000 to 2024-04-23 19:35:19 +0000
- fix(install): Don't respect MSRV for non-local installs (rust-lang/cargo#13790)
- gate some libc usages under cfg(unix), drop os_info features (rust-lang/cargo#13782)
- feat(resolver): Add default Edition2024 to resolver v3 (rust-lang/cargo#13785)
- Fix 2 tests for offline execution (rust-lang/cargo#13789)
- fix(toml): Report `_` fied variants (e.g. `dev_dependencies`) as deprecated (rust-lang/cargo#13783)
- feat(resolver): Add v3 resolver for MSRV-aware resolving (rust-lang/cargo#13776)
- Unused dependencies cleanup (rust-lang/cargo#13778)

r? ghost
@rustbot rustbot added this to the 1.79.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels
A-credential-provider Area: credential provider for storing and retreiving credentials S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
5 participants
@klensy @rustbot @weihanglo @bors @epage