Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Iterate on --breaking docs #14047

Merged
merged 1 commit into from
Jun 12, 2024
Merged

docs: Iterate on --breaking docs #14047

merged 1 commit into from
Jun 12, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Jun 11, 2024

This is a follow up to #13979 to try to clarify things in prep for users testing this.

This is a follow up to rust-lang#13979 to try to clarify things in prep for users
testing this.
@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-update S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2024
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. r=me when nit is fixed.

src/doc/man/cargo-update.md Outdated Show resolved Hide resolved
@epage
Copy link
Contributor Author

epage commented Jun 12, 2024

@bors r=weihanglo

@bors
Copy link
Collaborator

bors commented Jun 12, 2024

📌 Commit 6bd7623 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2024
@bors
Copy link
Collaborator

bors commented Jun 12, 2024

⌛ Testing commit 6bd7623 with merge 30e5580...

@bors
Copy link
Collaborator

bors commented Jun 12, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 30e5580 to master...

@bors bors merged commit 30e5580 into rust-lang:master Jun 12, 2024
22 checks passed
@epage epage deleted the breaking branch June 12, 2024 19:21
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2024
Update cargo

13 commits in 4dcbca118ab7f9ffac4728004c983754bc6a04ff..a1f47ec3f7cd076986f1bfcd7061f2e8cb1a726e
2024-06-11 16:27:02 +0000 to 2024-06-15 01:10:07 +0000
- Change verification order during packaging. (rust-lang/cargo#14074)
- Update git2 for libgit2 1.8.1 (rust-lang/cargo#14067)
- Fix some documentation misspellings (rust-lang/cargo#14066)
- chore(deps): update msrv (1 version) to v1.79 (rust-lang/cargo#14063)
- test: Redact conditional compile-fail warning (rust-lang/cargo#14064)
- Migrate a few test files to snapbox (rust-lang/cargo#14048)
- docs(contrib): Improve triage instructions (rust-lang/cargo#14052)
- chore(ci): Upgrade cargo-semver-checks (rust-lang/cargo#14062)
- Revert rust-lang/cargo#13630 as rustc ignores `-C strip` on MSVC (rust-lang/cargo#14061)
- test: migrate features_are_quoted to snapbox (rust-lang/cargo#14051)
- Add assert redactions (rust-lang/cargo#14054)
- test: migrate build_script_env to snapbox (rust-lang/cargo#14044)
- docs: Iterate on --breaking docs (rust-lang/cargo#14047)

r? ghost
@ehuss ehuss added this to the 1.81.0 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-update S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants