-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize the target
paths
#14497
base: master
Are you sure you want to change the base?
Normalize the target
paths
#14497
Conversation
e14e582
to
2fba2ad
Compare
2fba2ad
to
0b72c74
Compare
bin
table.target
paths
d71aea5
to
90753b6
Compare
ea8f33e
to
a15bb7a
Compare
In the But it is not very aceptable for I also want to apply the |
Hmm, sounds like That also makes me question using it elsewhere. I forgot that we leave these paths relative. I wonder if we should make the absolute during normalization and relative during publish. |
It's not work for
This way is trickier than I thought. |
a15bb7a
to
910d06b
Compare
9b4515c
to
ef810f6
Compare
r? @epage
See my PR description, I think this problem has been improved, please continue to review and leave valuable comments |
Looking at
its telling me what its doing. What I'm wondering is why this route was chosen. |
e935a54
to
ccd36d9
Compare
☔ The latest upstream changes (presumably #14591) made this pull request unmergeable. Please resolve the merge conflicts. |
What does this PR try to resolve?
The
targets
path of thenormalized_toml
could be relative, which isn't user-friendly.What is this PR doing?
target
path absolute then apply thepaths::normalize_path
to remove the relative part.package_root
during packaging.The
package.build
field doesn't really apply to this process as it's not stores as aPATH
, it needs to change to path and apply the above process then turn it to string, thats very clumsy.Fixes #14227
How should we test and review this PR?
Add a test originted from the issue, and fixing it in the next commit.
Additional information