-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and Rust that's used #1885
Conversation
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
r? @huonw |
let ret = f(&mut |url, username, allowed| { | ||
let creds = if allowed.contains(git2::SSH_KEY) || | ||
called += 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kinda strange, could you add a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, comment added!
a0805f7
to
3253218
Compare
@bors r+ |
📌 Commit 3253218 has been approved by |
⌛ Testing commit 3253218 with merge 60b1f2d... |
💔 Test failed - cargo-win-msvc-32 |
3253218
to
02b0b8c
Compare
@bors: r=huonw |
📌 Commit 02b0b8c has been approved by |
⌛ Testing commit 02b0b8c with merge b1ced5d... |
💔 Test failed - cargo-win-msvc-32 |
☔ The latest upstream changes (presumably #1902) made this pull request unmergeable. Please resolve the merge conflicts. |
bb3d152
to
78fe4a7
Compare
@bors: r+ 78fe4a7 |
⌛ Testing commit 78fe4a7 with merge 0c2fd15... |
78fe4a7
to
b62632c
Compare
@bors: r+ b62632c |
@bors: force |
⌛ Testing commit b62632c with merge feacdb6... |
💔 Test failed - cargo-mac-64 |
b62632c
to
dd8374b
Compare
@bors: r=huonw dd8374b |
⌛ Testing commit dd8374b with merge f381a00... |
💔 Test failed - cargo-mac-64 |
fd14ea6
to
a3fefeb
Compare
@bors: r+ a3fefeb |
⌛ Testing commit a3fefeb with merge 606bb69... |
💔 Test failed - cargo-win-gnu-32 |
442bc70
to
e89eee9
Compare
* Picks up a few breaking changes to dependency APIs, notably the tar-rs changes and git2-rs changes. * Builds should now work with VS 2015
e89eee9
to
530e1d1
Compare
* Picks up a few breaking changes to dependency APIs, notably the tar-rs changes and git2-rs changes. * Builds should now work with VS 2015
💔 Test failed - cargo-win-gnu-32 |
@bors: retry |
⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-win-msvc-32, cargo-win-msvc-64 are reusable. Rebuilding only cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64... |
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
and git2-rs changes.