-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore file locks on OSX NFS mounts #2720
Conversation
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit db595e9 has been approved by |
⌛ Testing commit db595e9 with merge 5345f1c... |
💔 Test failed - cargo-mac-64 |
db595e9
to
fe77f00
Compare
@bors: r=brson |
📌 Commit fe77f00 has been approved by |
⌛ Testing commit fe77f00 with merge f91e6fe... |
💔 Test failed - cargo-mac-32 |
fe77f00
to
89f77f4
Compare
@bors: r=brson |
📌 Commit 89f77f4 has been approved by |
⌛ Testing commit 89f77f4 with merge 57c71e5... |
💔 Test failed - cargo-mac-64 |
// do the same on OSX here. Note that ENOTSUP is an OSX_specific | ||
// constant. | ||
#[cfg(target_os = "macos")] | ||
Err(ref e) if e.raw_os_error() == Some(libc::ENOTSUP) => return Ok(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok(()) // no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops!
We already ignore NFS on Linux so let's do the same on OSX as well.
89f77f4
to
c8abb20
Compare
@bors: r=brson |
📌 Commit c8abb20 has been approved by |
Ignore file locks on OSX NFS mounts We already ignore NFS on Linux so let's do the same on OSX as well.
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
We already ignore NFS on Linux so let's do the same on OSX as well.