Expose rustc cfg values to build scripts #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
3 tasks
This commit is Cargo's portion of the implementation of [RFC 1721] where it will expose values printed by `rustc --print cfg` to build scripts. [RFC 1721]: https://github.com/rust-lang/rfcs/blob/master/text/1721-crt-static.md This will in turn be used to communicate features like `-C target-feature=+crt-static` which can be used to compile objects for statically linking against the msvcrt on MSVC.
alexcrichton
force-pushed
the
target-feature
branch
from
920ebf1
to
23587ee
Compare
|
@bors r+ |
|
📌 Commit 23587ee has been approved by |
bors
added a commit
that referenced
this pull request
Nov 3, 2016
Expose rustc cfg values to build scripts This commit is Cargo's portion of the implementation of [RFC 1721] where it will expose values printed by `rustc --print cfg` to build scripts. [RFC 1721]: https://github.com/rust-lang/rfcs/blob/master/text/1721-crt-static.md This will in turn be used to communicate features like `-C target-feature=+crt-static` which can be used to compile objects for statically linking against the msvcrt on MSVC.
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is Cargo's portion of the implementation of RFC 1721 where it will
expose values printed by
rustc --print cfgto build scripts.This will in turn be used to communicate features like
-C target-feature=+crt-staticwhich can be used to compile objects for staticallylinking against the msvcrt on MSVC.