Allow doc tests to run on proc macro crates #3552
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks! Can you also add a test for this? |
|
@bors: r+ Thanks! |
|
📌 Commit b3b8b7e has been approved by |
Allow doc tests to run on proc macro crates Fixes #3545 Since `--test` works for rustc, doctests should also work. Currently cargo isn't setup to run doctests for proc macro crates, this PR adds them to the list. Currently rustdoc can run doctests for proc-macro crates, but the `phase_2_configure_and_expand` call` triggers the following warning: ``` the `#[proc_macro_derive]` attribute is only usable with crates of the `proc-macro` crate type ``` So perhaps this PR should wait until I've finished creating/testing the PR for rustc.
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #3545
Since
--testworks for rustc, doctests should also work. Currently cargo isn't setup to run doctests for proc macro crates, this PR adds them to the list.Currently rustdoc can run doctests for proc-macro crates, but the
phase_2_configure_and_expandcall` triggers the following warning:So perhaps this PR should wait until I've finished creating/testing the PR for rustc.