Relax overly strict asserts in dependency queue #3921
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #3947) made this pull request unmergeable. Please resolve the merge conflicts. |
Don't actually need to assert that these are unique, it works both ways and we can have flavorful dependency graphs which otherwise trigger the assertions. Closes rust-lang#3902
alexcrichton
force-pushed
the
less-asserts
branch
from
cc94ba3
to
2511141
Compare
|
r? @matklad |
|
Hm, I would say that |
|
Yeah I felt the same way but couldn't find an easy way to implement that with resolve today so I figured I'd just let it slide as it's harmless anyway. This'd just take more effort to figure out how to reject this case. |
|
Yeah, accepting it is better then panicking! @bors r+ |
|
📌 Commit 2511141 has been approved by |
Relax overly strict asserts in dependency queue Don't actually need to assert that these are unique, it works both ways and we can have flavorful dependency graphs which otherwise trigger the assertions. Closes #3902
|
☀️ Test successful - status-appveyor, status-travis |
Don't actually need to assert that these are unique, it works both ways and we
can have flavorful dependency graphs which otherwise trigger the assertions.
Closes #3902