Fix a flaky concurrent test with correct locking #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent refactoring to clone the bare registry left in an accidental path where index checkouts could clobber one another. This commit updates the logic with proper locking and attempt ordering, attempting a full retry of the open operation after the index locked.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 7b44acc has been approved by |
bors
added a commit
that referenced
this pull request
May 16, 2017
Fix a flaky concurrent test with correct locking The recent refactoring to clone the bare registry left in an accidental path where index checkouts could clobber one another. This commit updates the logic with proper locking and attempt ordering, attempting a full retry of the open operation after the index locked.
|
☀️ Test successful - status-appveyor, status-travis |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactoring to clone the bare registry left in an accidental path
where index checkouts could clobber one another. This commit updates the logic
with proper locking and attempt ordering, attempting a full retry of the open
operation after the index locked.