Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new CARGO_MANIFEST_DIR environment variable #434

Merged
merged 1 commit into from
Aug 25, 2014

Conversation

alexcrichton
Copy link
Member

All subprocesses will now be invoked with CARGO_MANIFEST_DIR pointing at the root of the
source directory that they are working on (compiling). This commit also
reorganizes the version environment variables to use the new infrastructure.

Closes #433

@huonw
Copy link
Member

huonw commented Aug 25, 2014

This SRC_DIR variable is pointing to the manifest, not to .../src, right?

Maybe MANIFEST_DIR would be clearer (or CARGO_MANIFEST_DIR)?

@alexcrichton
Copy link
Member Author

Hm good point, the environment variable is an absolute path to the directory containing the manifest.

All subprocesses will now be invoked with CARGO_MANIFEST_DIR pointing at the
root of the source directory that they are working on (compiling). This commit
also reorganizes the version environment variables to use the new
infrastructure.

Closes rust-lang#433
@alexcrichton alexcrichton changed the title Add a new SRC_DIR environment variable Add a new CARGO_MANIFEST_DIR environment variable Aug 25, 2014
bors added a commit that referenced this pull request Aug 25, 2014
All subprocesses will now be invoked with CARGO_MANIFEST_DIR pointing at the root of the
source directory that they are working on (compiling). This commit also
reorganizes the version environment variables to use the new infrastructure.

Closes #433
@bors bors merged commit 76ccf94 into rust-lang:master Aug 25, 2014
@alexcrichton alexcrichton deleted the issue-433 branch August 25, 2014 19:52
bors added a commit to alexcrichton/cargo that referenced this pull request Sep 2, 2014
All subprocesses will now be invoked with CARGO_MANIFEST_DIR pointing at the root of the
source directory that they are working on (compiling). This commit also
reorganizes the version environment variables to use the new infrastructure.

Closes rust-lang#433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow tests to read data dynamically from a package
3 participants