Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hamcrest to 0.1.5 #4886

Closed
wants to merge 1 commit into from
Closed

Conversation

Eijebong
Copy link
Contributor

@Eijebong Eijebong commented Jan 2, 2018

The main change is that the assert_that function is now deprecated and
is replaced by the assert_that! macro hence the size of that patch.
Since that macro needs some traits to be in scope, I changed every
hamcrest import to be just use hamcrest::prelude::*.

The main change is that the `assert_that` function is now deprecated and
is replaced by the `assert_that!` macro hence the size of that patch.
Since that macro needs some traits to be in scope, I changed every
hamcrest import to be just `use hamcrest::prelude::*`.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks! I've sort of personally been content to stick to an older version because it works for us and I'm not sure there's much active development upstream to take advantage of. If we're consdering large changes to the test suite I think it's worth considering just dropping this dependency altogether. IIRC we only use one or two small features and we could relatively easily vendor them into cargotest perhaps?

@matklad
Copy link
Member

matklad commented Jan 6, 2018

@alexcrichton yeah, I personally never was thrilled by fluent assertion libraries. It seems simpler to just use assert! most of the time and switch to hand-crafted assetion messages and diffing functions for complex cases. So, +1 from me to keeping status quo or dropping the dependency.

(Interestingly, what I find useful is py.test style supercharging of the build-in assert, and we might get something similar once rust-lang/rfcs#2011 is implemented).

@bors
Copy link
Collaborator

bors commented Jan 9, 2018

☔ The latest upstream changes (presumably #4770) made this pull request unmergeable. Please resolve the merge conflicts.

@Eijebong
Copy link
Contributor Author

Sure. I was just trying to reduce the number of old dependencies in cargo ^_^
If you'd prefer to rewrite all the test suite without harmcrest, that's fine by me (maybe I'll try to do it someday if I find the motivation)

@Eijebong Eijebong closed this Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants