Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for cargo rustc in a workspace. #5447

Merged
merged 1 commit into from
May 1, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented May 1, 2018

Fixes #5371

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented May 1, 2018

📌 Commit 037a879 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 1, 2018

⌛ Testing commit 037a879 with merge a75ade95a57d461e8a588291d251711a4123f166...

@bors
Copy link
Contributor

bors commented May 1, 2018

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 1, 2018

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented May 1, 2018

📌 Commit 037a879 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 1, 2018

⌛ Testing commit 037a879 with merge 181de52...

bors added a commit that referenced this pull request May 1, 2018
Better error message for `cargo rustc` in a workspace.

Fixes #5371
@bors
Copy link
Contributor

bors commented May 1, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 181de52 to master...

@bors bors merged commit 037a879 into rust-lang:master May 1, 2018
@ehuss
Copy link
Contributor Author

ehuss commented May 1, 2018

@alexcrichton Do we know why the test failed?

@alexcrichton
Copy link
Member

@ehuss oh the appveyor failure is a known spurious failure we just haven't gotten around to diagnosing yet

@ehuss ehuss added this to the 1.27.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo rustc in root of workspace gives wrong error
4 participants