Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo install using a workspace target dir #5685

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

alexcrichton
Copy link
Member

Closes #5662

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad
Copy link
Member

matklad commented Jul 5, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 5, 2018

📌 Commit d1ef031 has been approved by matklad

@bors
Copy link
Collaborator

bors commented Jul 5, 2018

⌛ Testing commit d1ef031 with merge ebeed97...

bors added a commit that referenced this pull request Jul 5, 2018
…tklad

Fix `cargo install` using a workspace target dir

Closes #5662
@bors
Copy link
Collaborator

bors commented Jul 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing ebeed97 to master...

@bors bors merged commit d1ef031 into rust-lang:master Jul 5, 2018
@Keruspe
Copy link
Contributor

Keruspe commented Jul 5, 2018

@alexcrichton if 1.27.1 happens, would this be a good candidate for a backport? This breaks packaging crates using workspaces in sandboxes environments

@alexcrichton alexcrichton deleted the fix-cargo-install-target-dir branch July 5, 2018 19:54
@alexcrichton
Copy link
Member Author

I think for the stable point release it's a bit too close, but we can certainly backport this to beta

bors added a commit that referenced this pull request Jul 5, 2018
[beta] Fix `cargo install` using a workspace target dir

Backport of #5685
@ehuss ehuss modified the milestones: 1.29.0, 1.28.0 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo install doesn't follow workspace target
6 participants