Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ANSI escape code to clear line #6233

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Use ANSI escape code to clear line #6233

merged 1 commit into from
Oct 28, 2018

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Oct 28, 2018

This eliminates the trailing spaces that Cargo used to use for clearing a line of output. Trailing spaces are problematic because they take up space on the next line when reducing the width of a terminal.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

This eliminates the trailing spaces that Cargo used to use for clearing
a line of output. Trailing spaces are problematic because they take up
space on the next line when reducing the width of a terminal.
@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 28, 2018

📌 Commit d534875 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Oct 28, 2018

⌛ Testing commit d534875 with merge c5b9258...

bors added a commit that referenced this pull request Oct 28, 2018
Use ANSI escape code to clear line

This eliminates the trailing spaces that Cargo used to use for clearing a line of output. Trailing spaces are problematic because they take up space on the next line when reducing the width of a terminal.
@bors
Copy link
Collaborator

bors commented Oct 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c5b9258 to master...

@bors bors merged commit d534875 into rust-lang:master Oct 28, 2018
bors added a commit that referenced this pull request Nov 8, 2018
Disable progress bar on CI.

Due to the recent change (#6233) to use ansi escape codes to clear the progress bar, Travis logs are looking quite odd. Generally you don't want the progress bar during CI builds anyways, so just disable it if "CI" is set, which most of the CI services do.
@ehuss ehuss added this to the 1.32.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants