map_dependencies is doing a deep clone, so lets make it cheaper
#7326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ehuss
approved these changes
Sep 4, 2019
|
@bors: r=ehuss |
|
📌 Commit 880337a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 4, 2019
`map_dependencies` is doing a deep clone, so lets make it cheaper This removes a `FeatureMap::clone` that I noticed when profiling no-op builds of cargo, benchmarks show a ~5% improvement. Looks like #6880 means that there is a ref to every `Summery` so the `Rc::make_mut` dose a deep clone.
|
☀️ Test successful - checks-azure |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Sep 13, 2019
Update cargo 11 commits in fe0e5a48b75da2b405c8ce1ba2674e174ae11d5d..9655d70af8a6dddac238e3afa2fec75088c9226f 2019-09-04 00:51:27 +0000 to 2019-09-10 18:16:11 +0000 - Home docs: fix broken links, misspellings, style fixes, clarifications. (rust-lang/cargo#7348) - add readme key to cargos manifest. (rust-lang/cargo#7347) - Explicitly ignore some results (rust-lang/cargo#7340) - Don't resolve std's optional dependencies (rust-lang/cargo#7337) - Add `alloc` and `proc_macro` to libstd crates (rust-lang/cargo#7336) - doc: capitalization change for consistency. (rust-lang/cargo#7334) - Fix test for changes in plugin API. (rust-lang/cargo#7335) - Fix some man pages where the files weren't rebuilt. (rust-lang/cargo#7332) - guide: add section about the cargo home (rust-lang/cargo#7314) - `map_dependencies` is doing a deep clone, so lets make it cheaper (rust-lang/cargo#7326) - don't need to copy this string (rust-lang/cargo#7324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a
FeatureMap::clonethat I noticed when profiling no-op builds of cargo, benchmarks show a ~5% improvement. Looks like #6880 means that there is a ref to everySummeryso theRc::make_mutdose a deep clone.