Disable preserving mtimes on archives #7465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are just wasted syscalls for our purposes, no need to issue updates to the modification/creation/access times of files we unpack!
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Good catch. @bors r+ |
|
📌 Commit 8c92e88 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 2, 2019
Disable preserving mtimes on archives These are just wasted syscalls for our purposes, no need to issue updates to the modification/creation/access times of files we unpack!
|
☀️ Test successful - checks-azure |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Oct 8, 2019
Update Cargo To pull rust-lang/cargo#7482 List of merged PRs: - Fix wrong directories in PATH on Windows (rust-lang/cargo#7482) - Update SPDX list to 3.6 (rust-lang/cargo#7481) - Mark Emscripten's .wasm files auxiliary (rust-lang/cargo#7476) - Update `curl-sys` dependency requirement (rust-lang/cargo#7464) - add dependencies for `pkg-config` (rust-lang/cargo#7443) - Removing hash from output files when using MSVC (rust-lang/cargo#7400) - Disable preserving mtimes on archives (rust-lang/cargo#7465) - Removed redundant borrow (rust-lang/cargo#7462) - Public dependency refactor and re-allow backjumping (rust-lang/cargo#7361) - unify the quote in Cargo.toml (rust-lang/cargo#7461)
This was referenced Nov 14, 2019
bors-servo
pushed a commit
to servo/libfontconfig
that referenced
this pull request
Dec 5, 2019
Fix intermittent build error This is a symptom of a change in Cargo (rust-lang/cargo#7465) that no longer preserves the mtime of files extracted during the package download process. This means that generated files included in this repository can end up being regenerated unnecessarily unless we explicitly force them to be treated as more recent than their source files.
|
That happened to be the solution for #6238 issue, so no Rust compiling from FAT devices again. It broke my Rust from USB environment :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just wasted syscalls for our purposes, no need to issue
updates to the modification/creation/access times of files we unpack!