Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all Clippy suggestions (but not add it to CI 🙃) #7574

Merged
merged 16 commits into from
Nov 15, 2019
Merged

Fix all Clippy suggestions (but not add it to CI 🙃) #7574

merged 16 commits into from
Nov 15, 2019

Commits on Nov 12, 2019

  1. add clippy to the pipelines

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    4a1207c View commit details
    Browse the repository at this point in the history

  2. remove suppression of clippy lint too_many_arguments

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    b98673f View commit details
    Browse the repository at this point in the history

  3. implement clippy suggestion to use or_insert_with

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    018e8de View commit details
    Browse the repository at this point in the history

  4. implement clippy suggestion to use if as an expression

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    230d353 View commit details
    Browse the repository at this point in the history

  5. implement clippy suggestion to remove needless return

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    b31bf04 View commit details
    Browse the repository at this point in the history

  6. implement clippy suggestion to use or_else instead of or to avoid… 

    … unintended side effects
    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    b7e1778 View commit details
    Browse the repository at this point in the history

  7. refactor method to avoid calling unwrap() explicitly

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    e1501f1 View commit details
    Browse the repository at this point in the history

  8. implement clippy suggestion to remove needless return

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    37ec84d View commit details
    Browse the repository at this point in the history

  9. implement clippy suggestion to remove redundant to_string

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    b3fe6b7 View commit details
    Browse the repository at this point in the history

  10. suppress clippy lint needless_doctest_main

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    b590183 View commit details
    Browse the repository at this point in the history

  11. silence several clippy lints in tests

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    6d21f9e View commit details
    Browse the repository at this point in the history

  12. implement clippy suggestion not to use assert_eq on ()

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    60f88a4 View commit details
    Browse the repository at this point in the history

  13. suppress clippy lint block_in_if_condition_stmt in the testsuite be… 

    …cause fixing it upsets rustfmt
    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    e8a8f76 View commit details
    Browse the repository at this point in the history

  14. implement clippy suggestion to remove redundant clone

    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    1c5861c View commit details
    Browse the repository at this point in the history

  15. suppress clippy lint inefficient_to_string - according to reviewers… 

    …' preference
    @igor-makarov
    igor-makarov committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    2a49ac9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Remove clippy from pipelines - @Eh2406 asked that the commit will be … 

    …kept

This reverts commit 4a1207c.
    @igor-makarov
    igor-makarov committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    1432651 View commit details
    Browse the repository at this point in the history