Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.45 beta backports #8335

Merged
merged 2 commits into from
Jun 5, 2020
Merged

1.45 beta backports #8335

merged 2 commits into from
Jun 5, 2020

Commits on Jun 5, 2020

  1. Auto merge of rust-lang#8290 - ehuss:fix-lld-freshness, r=alexcrichton 

    Fix fingerprinting for lld on Windows with dylib.

This fixes an issue where if `lld` is used on Windows, dynamic libraries will never be treated as "fresh". This is a regression from rust-lang#8210 where Cargo is expecting export files to be created, but lld does not create these.

The solution is to ignore "Auxiliary" files in fingerprinting, which AFAIK aren't really needed (only the primary output files really matter).

Fixes rust-lang#8284
    @bors @ehuss
    bors authored and ehuss committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    bd57eb5 View commit details
    Browse the repository at this point in the history

  2. Auto merge of rust-lang#8329 - ehuss:apple-no-hash, r=alexcrichton 

    Don't hash executable filenames on apple platforms.

Due to some recent changes to the backtrace crate, backtraces on apple platforms haven't been working (they are missing line/filename information). The reason is that previously libbacktrace would hunt through the directory for any matching file in the `.dSYM` directory. The new implementation expects a file matching the executable name exactly (which no longer includes the hash because Cargo renames it).

The solution here is to not include a hash in the executable filename. This matches the behavior on Windows which does it for a similar reason (paths are embedded in pdb files).

The downside is that switching between different settings (like different features) causes Cargo to rebuild the binary each time.  I don't think this is a particularly common use case, at least I've not heard any complaints about this behavior on Windows.

Fixes rust-lang/rust#72550
    @bors @ehuss
    bors authored and ehuss committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    fcfb13c View commit details
    Browse the repository at this point in the history