Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo 'more then' -> 'more than' in error and comments #8581

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fix typo 'more then' -> 'more than' in error and comments #8581

merged 1 commit into from
Aug 3, 2020

Conversation

toshokan
Copy link
Contributor

@toshokan toshokan commented Aug 3, 2020

There were typos in a reported resolution error and in some comments

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2020
@Eh2406
Copy link
Contributor

Eh2406 commented Aug 3, 2020

That is the kind of mistake I would make. Thank you for finding it!

@alexcrichton
Copy link
Member

@bors: r=Eh2406

@bors
Copy link
Collaborator

bors commented Aug 3, 2020

📌 Commit caa8f78 has been approved by Eh2406

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2020
@bors
Copy link
Collaborator

bors commented Aug 3, 2020

⌛ Testing commit caa8f78 with merge af539d2...

@bors
Copy link
Collaborator

bors commented Aug 3, 2020

☀️ Test successful - checks-actions
Approved by: Eh2406
Pushing af539d2 to master...

@bors bors merged commit af539d2 into rust-lang:master Aug 3, 2020
@ehuss ehuss mentioned this pull request Aug 5, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2020
@bors
Auto merge of rust-lang#75169 - ehuss:update-cargo, r=ehuss
8b84156 
Update cargo

8 commits in 2d5c2381e4e50484bf281fc1bfe19743aa9eb37a..1653f354644834073d6d2541e27fae94588e685e
2020-07-31 21:56:08 +0000 to 2020-08-04 23:14:37 +0000
- Fix close_output test. (rust-lang/cargo#8587)
- clippy fixes, use matches! macro in more places (rust-lang/cargo#8575)
- Display embedded man pages for built-in commands. (rust-lang/cargo#8456)
- Add mdman for generating man pages. (rust-lang/cargo#8577)
- Fix typo 'more then' -> 'more than' in error and comments (rust-lang/cargo#8581)
- cargo login: make login message less ambiguous (rust-lang/cargo#8579)
- Fix broken link in Build Cache chapter. (rust-lang/cargo#8578)
- Fix intra-doc tests for renamed lint. (rust-lang/cargo#8576)
@ehuss ehuss added this to the 1.47.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@toshokan @rust-highfive @Eh2406 @alexcrichton @bors @ehuss