Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --include-ignored to cargo test options #9190

Closed
wants to merge 2 commits into from

Conversation

trevarj
Copy link

@trevarj trevarj commented Feb 20, 2021

This option has been stabilized in rust-lang/rust#80053

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2021
@ehuss
Copy link
Contributor

ehuss commented Feb 20, 2021

Thanks for the PR! However, the man pages document the options of cargo, not the test harness. Currently, I don't think there is any online documentation for the test harness (only the output from cargo test -- --help which is documented here).

I have felt it would be good to have libtest-specific documentation somewhere. The rustc book might be as good as place as any, and then the cargo docs could link to that. Do you have any interest in working on that? If not, that's ok.

@trevarj
Copy link
Author

trevarj commented Feb 20, 2021

@ehuss Hi, I don't think I'm well-versed enough in libtest / rustc for this. I just simply spent an embarrassing amount of time looking for --include-ignored 😞

Feel free to close this!

@trevarj trevarj closed this Feb 20, 2021
@trevarj trevarj deleted the patch-1 branch February 20, 2021 20:22
@ehuss
Copy link
Contributor

ehuss commented Feb 20, 2021

No worries. I just posted rust-lang/rust#82350 to try to fill that hole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants