Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make future-incompat-report output more user-friendly #9953

Merged
merged 13 commits into from
Oct 19, 2021
Merged

Make future-incompat-report output more user-friendly #9953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d5538c3
Make future-incompat-report output more user-friendly
Aaron1011 Aug 27, 2021
20340e1
Rename arg and adjust tests
Aaron1011 Oct 5, 2021
315d605
Rename to per_package
Aaron1011 Oct 8, 2021
ce25922
Change package spec
Aaron1011 Oct 8, 2021
49ae189
Combined newer versions into single list
Aaron1011 Oct 8, 2021
5afcce6
Run fmt
Aaron1011 Oct 8, 2021
704540d
Use double-quotes for package spec
Aaron1011 Oct 8, 2021
6f18507
Display update message in report
Aaron1011 Oct 12, 2021
f57be6f
Adjust message and move code to future_incompat module
Aaron1011 Oct 16, 2021
085f04a
Adjust suggestions
Aaron1011 Oct 18, 2021
958f2fc
Display more information in report
Aaron1011 Oct 18, 2021
5c3b380
Adjust comments
Aaron1011 Oct 18, 2021
7ffba67
Run fmt
Aaron1011 Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/bin/cargo/commands/report.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ pub fn cli() -> App {
"identifier of the report generated by a Cargo command invocation",
)
.value_name("id"),
),
)
.arg_package("Package to display a report for"),
)
}

Expand All @@ -38,7 +39,8 @@ fn report_future_incompatibilies(config: &Config, args: &ArgMatches<'_>) -> CliR
let id = args
.value_of_u32("id")?
.unwrap_or_else(|| reports.last_id());
let report = reports.get_report(id, config)?;
let krate = args.value_of("package");
let report = reports.get_report(id, config, krate)?;
drop_println!(config, "{}", REPORT_PREAMBLE);
drop(config.shell().print_ansi_stdout(report.as_bytes()));
Ok(())
Expand Down
Loading