Add empty jobserver feature.
#1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we removed implicit features, anyone that used this crate and specifically enabled `jobserver` would now be broken as this crate no longer had that feature (or a couple of others). Add a placeholder `jobserver` feature that doesn't enable `parallel` (just as it didn't enable it before). The other features removed weren't likely to be enabled by anyone.
|
This should fix the problem reported in #1099 by @rafales. The actual problem should also be reported to the @solana-labs crew. |
|
I reported it and the issue was auto-closed as the whole thing has been forked. I looked in the fork and it no longer uses |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we removed implicit features, anyone that used this crate and specifically enabled
jobserverwould now be broken as this crate no longer had that feature (or a couple of others).Add a placeholder
jobserverfeature that doesn't enableparallel(just as it didn't enable it before).The other features removed weren't likely to be enabled by anyone.