Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set environment variables in Tool from try_get_compiler #851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oblique
Copy link

@oblique oblique commented Aug 9, 2023

get_compiler wasn't forwarding the environment variables modifications to Tool, however these are very useful configurations, especially under MacOS.

@oblique
Copy link
Author

oblique commented Sep 5, 2023

@Amanieu Sorry for pinging you, I didn't know who else to ping. What is you opinion/review on this?

@youknowone
Copy link
Contributor

Is this related to lost -isysroot problem with AppleClang?

@oblique
Copy link
Author

oblique commented Sep 12, 2023

@youknowone I don't know about the problem. Do you have a link to it? If the problem is when using Tool, then maybe it is related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants