Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate UB fix in floatsidf and floatsisf #85

Closed
japaric opened this issue Oct 1, 2016 · 3 comments · Fixed by #92
Closed

Integrate UB fix in floatsidf and floatsisf #85

japaric opened this issue Oct 1, 2016 · 3 comments · Fixed by #92

Comments

@japaric
Copy link
Member

japaric commented Oct 1, 2016

cf. rust-lang/compiler-rt#24

These fixes are not in the llvm-mirror/compiler-rt repo which we are using.
@alexcrichton
Copy link
Member

Ideally we'd upstream, but that may take a bit...

Agreed should use a fork in the meantime to speed things along.

@japaric
Copy link
Member Author

japaric commented Oct 4, 2016

So, we could just switch to the rust-lang/compiler-rt repo.

@alexcrichton
Copy link
Member

👍

japaric pushed a commit that referenced this issue Oct 4, 2016
switch compiler-rt to rust-lang's fork
2706d92 
this fork has been patched against the UB in floatsidf and floasisf
closes #85
@japaric japaric mentioned this issue Oct 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch compiler-rt to rust-lang's fork rust-lang/compiler-builtins
2 participants
@alexcrichton @japaric