Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 32-bit and 64-bit stderr/stdout files for ui tests #365

Closed
3 tasks done
oli-obk opened this issue Sep 20, 2020 · 3 comments
Closed
3 tasks done

Add 32-bit and 64-bit stderr/stdout files for ui tests #365

oli-obk opened this issue Sep 20, 2020 · 3 comments
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Sep 20, 2020

Proposal

Similarly to how mir-opt tests can generate an output file for each bit width, we would allow ui tests to do the same for its stderr/stdout dump files. This would be entirely opt-in, so all ui tests keep behaving as they do now, but if you add

// emit-stderr-for-each-bitwidth

to the test file, then you get a .64bit.stderr file instead of a plain .stderr file. When you run the test on 32 bit you get a .32bit.stderr file. Only the file for your platform is tested, so you need to rerun the test with --target i686-unknown-linux-gnu on a 64 bit host in order to check the 32 bit test file.

The reason I am suggesting this is that it's nearly impossible to specify a useful normalization regex for rust-lang/rust#76881 . The point is to test the output, ideally for each platform individually.

Mentors or Reviewers

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@oli-obk oli-obk added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Sep 20, 2020
@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Sep 20, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Sep 23, 2020
@estebank
Copy link

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jan 28, 2021
hameerabbasi added a commit to hameerabbasi/rust that referenced this issue Feb 6, 2021
m-ou-se added a commit to m-ou-se/rust that referenced this issue Feb 8, 2021
Add option to emit compiler stderr per bitwidth.

See rust-lang/compiler-team#365

r? `@oli-obk`
@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 9, 2021

This has been implemented in rust-lang/rust#81817 now

@oli-obk oli-obk closed this as completed Feb 9, 2021
@apiraino apiraino removed the final-comment-period The FCP has started, most (if not all) team members are in agreement label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

5 participants