Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NEEDS_SUBST and NEEDS_INFER #617

Closed
1 of 3 tasks
BoxyUwU opened this issue Apr 14, 2023 · 3 comments
Closed
1 of 3 tasks

Rename NEEDS_SUBST and NEEDS_INFER #617

BoxyUwU opened this issue Apr 14, 2023 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 14, 2023

Proposal

Rename the type flags NEEDS_SUBST to HAS_PARAM and NEEDS_INFER to HAS_INFER. This is more consistent with the naming of HAS_TY_PARAM, HAS_CT_PARAM, HAS_RE_PARAM, HAS_TY_INFER, HAS_CT_INFER, HAS_RE_INFER flags.

NEEDS_SUBST just seems somewhat wrong, just because a type has params in it doesnt mean you should be calling subst on it, HAS_PARAM seems to reflect better what this is actually detecting.

Mentors or Reviewers

I will implement it myself, it should be simple to review

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@BoxyUwU BoxyUwU added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Apr 14, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 14, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Apr 14, 2023

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Apr 14, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 20, 2023
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Apr 25, 2023
@BoxyUwU BoxyUwU mentioned this issue Apr 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 27, 2023
@bors
Auto merge of rust-lang#110882 - BoxyUwU:rename-some-ty-flags, r=comp…
6ce2273 
…iler-errors

rename `NEEDS_SUBST` and `NEEDS_INFER`

implements rust-lang/compiler-team#617
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oli-obk @apiraino @BoxyUwU @rustbot