-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condemn asmjs-unknown-emscripten
to push a boulder up a hill for eternity
#668
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. cc @rust-lang/compiler @rust-lang/compiler-contributors |
@rustbot second |
I'm quite amused but unfortunately I don't know what is actually being proposed. 😂 |
@rfcbot concern clarify-verbiage @workingjubilee could you clarify and expand a little bit the proposal? We don't lack sense of humour but perhaps that would help a wider audience to understand. Thanks! |
Well, the This would hypothetically negatively impact anyone who wishes to use the |
It should be noted this target is not tier 3. Some people seem confused on that. It is tier 2. Y'know, like real platforms? Like So permitting it to exist in the Rust codebase is functionally a statement that we are okay with targets that e.g. emit 64-bit Arm instructions when they're supposed to emit x86 instructions. Or, say, Sparc instead of Arm. If this state of affairs is permitted to continue, this is effectively a statement that tier 2 targets are effectively meaningless definitions of "support". I have been admonished to adhere to "process" however, so I am filing a ridiculous proposal to rectify a ridiculous state of affairs instead of simply submitting a PR to remove the target immediately, which is what I would prefer to do. There is certainly a joke here, but it started well before I wrote anything into the "post an issue" box. |
@workingjubilee Could you edit your proposal to mention specifically whether Thanks! 🙂 |
@rustbot second |
@rustbot label -final-comment-period +major-change-accepted |
…s, r=b-naber Remove asmjs Fulfills [MCP 668](rust-lang/compiler-team#668). `asmjs-unknown-emscripten` does not work as-specified, and lacks essential upstream support for generating asm.js, so it should not exist at all.
…s, r=b-naber Remove asmjs Fulfills [MCP 668](rust-lang/compiler-team#668). `asmjs-unknown-emscripten` does not work as-specified, and lacks essential upstream support for generating asm.js, so it should not exist at all.
Rollup merge of rust-lang#117338 - workingjubilee:asmjs-meets-thanatos, r=b-naber Remove asmjs Fulfills [MCP 668](rust-lang/compiler-team#668). `asmjs-unknown-emscripten` does not work as-specified, and lacks essential upstream support for generating asm.js, so it should not exist at all.
Remove asmjs Fulfills [MCP 668](rust-lang/compiler-team#668). `asmjs-unknown-emscripten` does not work as-specified, and lacks essential upstream support for generating asm.js, so it should not exist at all.
Proposal
I believe this is the traditional punishment for those that cheat Death and find Death catching up with them again.
The target support code will be
placed beyond the reach of mortal handsremoved, because it is impossible to make the asmjs target functional again with any recent version of emscripten.Mentors or Reviewers
I recommend Thanatos, but any of the Chthonic gods will do.
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
The text was updated successfully, but these errors were encountered: