Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condemn asmjs-unknown-emscripten to push a boulder up a hill for eternity #668

Closed
1 of 3 tasks
workingjubilee opened this issue Aug 26, 2023 · 9 comments
Closed
1 of 3 tasks
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Aug 26, 2023

Proposal

I believe this is the traditional punishment for those that cheat Death and find Death catching up with them again.

The target support code will be placed beyond the reach of mortal hands removed, because it is impossible to make the asmjs target functional again with any recent version of emscripten.

Mentors or Reviewers

I recommend Thanatos, but any of the Chthonic gods will do.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@workingjubilee workingjubilee added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Aug 26, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Aug 26, 2023
@Noratrieb
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Aug 26, 2023
@RalfJung
Copy link
Member

I'm quite amused but unfortunately I don't know what is actually being proposed. 😂

@apiraino
Copy link
Contributor

apiraino commented Aug 26, 2023

@rfcbot concern clarify-verbiage

@workingjubilee could you clarify and expand a little bit the proposal? We don't lack sense of humour but perhaps that would help a wider audience to understand. Thanks!

@workingjubilee
Copy link
Member Author

Well, the asmjs-unknown-emscripten target is de facto dead, seeing as how it doesn't perform basic functions like "emitting object code". It is only "alive" i.e. in the rustc codebase and can be "used" for any purpose because apparently Death has been prevented from reaping it, somehow, so the proposal is to fix that by moving the target support code from the rustc codebase to Tartarus.

This would hypothetically negatively impact anyone who wishes to use the asmjs-unknown-emscripten, but so would the fact that the target is in truth only an unliving ghoul that does not emit the correct object code that is supposed to be runnable by a conventional JavaScript interpreter, but rather wasm32 instructions. Presumably if any users actually relied on that, someone would have at least complained loudly in the past 3 years.

@workingjubilee
Copy link
Member Author

It should be noted this target is not tier 3. Some people seem confused on that.

It is tier 2. Y'know, like real platforms? Like aarch64-apple-darwin?

So permitting it to exist in the Rust codebase is functionally a statement that we are okay with targets that e.g. emit 64-bit Arm instructions when they're supposed to emit x86 instructions. Or, say, Sparc instead of Arm. If this state of affairs is permitted to continue, this is effectively a statement that tier 2 targets are effectively meaningless definitions of "support".

I have been admonished to adhere to "process" however, so I am filing a ridiculous proposal to rectify a ridiculous state of affairs instead of simply submitting a PR to remove the target immediately, which is what I would prefer to do. There is certainly a joke here, but it started well before I wrote anything into the "post an issue" box.

@wesleywiser
Copy link
Member

@workingjubilee Could you edit your proposal to mention specifically whether asmjs-unknown-enscripten should be demoted to Cocytus Tier 3 or removed from the compiler and standard library entirely? I assume you would prefer the latter but it would be best to confirm.

Thanks! 🙂

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 1, 2023
@wesleywiser
Copy link
Member

@rustbot second

@apiraino
Copy link
Contributor

apiraino commented Oct 2, 2023

@rustbot label -final-comment-period +major-change-accepted

@apiraino apiraino closed this as completed Oct 2, 2023
@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Oct 2, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Oct 12, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 17, 2023
…s, r=b-naber

Remove asmjs

Fulfills [MCP 668](rust-lang/compiler-team#668).

`asmjs-unknown-emscripten` does not work as-specified, and lacks essential upstream support for generating asm.js, so it should not exist at all.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 17, 2023
…s, r=b-naber

Remove asmjs

Fulfills [MCP 668](rust-lang/compiler-team#668).

`asmjs-unknown-emscripten` does not work as-specified, and lacks essential upstream support for generating asm.js, so it should not exist at all.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 18, 2023
Rollup merge of rust-lang#117338 - workingjubilee:asmjs-meets-thanatos, r=b-naber

Remove asmjs

Fulfills [MCP 668](rust-lang/compiler-team#668).

`asmjs-unknown-emscripten` does not work as-specified, and lacks essential upstream support for generating asm.js, so it should not exist at all.
bors pushed a commit to rust-lang/miri that referenced this issue Nov 21, 2023
Remove asmjs

Fulfills [MCP 668](rust-lang/compiler-team#668).

`asmjs-unknown-emscripten` does not work as-specified, and lacks essential upstream support for generating asm.js, so it should not exist at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

6 participants