-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor worker #736
Merged
Merged
Refactor worker #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
force-pushed
the
refactor-worker
branch
from
August 31, 2024 18:11
e4100d3
to
cca4c3f
Compare
@bors r+ |
bors
added a commit
that referenced
this pull request
Aug 31, 2024
Refactor worker This moves all pushes of logs to the central server out of the execution of tasks and into the worker function, which ensures that we don't overwrite previous results for the same crate multiple times (when retrying its run). That should hopefully preserve the logs as well throughout the retries.
💔 Test failed - checks-actions |
This moves all pushes of logs to the central server out of the execution of tasks and into the worker function, which ensures that we don't overwrite previous results for the same crate multiple times (when retrying its run). That should hopefully preserve the logs as well throughout the retries.
Mark-Simulacrum
force-pushed
the
refactor-worker
branch
from
August 31, 2024 19:09
cca4c3f
to
d9bc6ab
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all pushes of logs to the central server out of the execution
of tasks and into the worker function, which ensures that we don't
overwrite previous results for the same crate multiple times (when
retrying its run). That should hopefully preserve the logs as well
throughout the retries.