crates.io is incorrectly disallowing feature names that start with numbers #1329
Comments
sgrif
added a commit
to sgrif/crates.io
that referenced
this issue
Apr 7, 2018
Diesel 1.2 had planned on renaming our `large-tables` and `huge-tables` features to `32-column-tables` and `64-column-tables` respectively, while also introducing the `128-column-tables` feature. This change was made several months ago in Diesel. Cargo will happily accept those as feature names, and resolve them properly from other crates. However while publishing Diesel 1.2, I ran into a snag mid-release when I realized that Cargo is incorrectly assuming that a feature name must be the same as a crate name. I suspect this is an artifact of the fact that feature names often are crate names (and perhaps in the past that was the only form of feature?). However, now they are an entirely separate thing, and we should allow the same set of feature names that Cargo does. (As an aside, do we want to apply the same 64 character limit that we apply to crate names to feature names?) Fixes rust-lang#1329.
sgrif
added a commit
to sgrif/crates.io
that referenced
this issue
Apr 7, 2018
Diesel 1.2 had planned on renaming our `large-tables` and `huge-tables` features to `32-column-tables` and `64-column-tables` respectively, while also introducing the `128-column-tables` feature. This change was made several months ago in Diesel. Cargo will happily accept those as feature names, and resolve them properly from other crates. However while publishing Diesel 1.2, I ran into a snag mid-release when I realized that Cargo is incorrectly assuming that a feature name must be the same as a crate name. I suspect this is an artifact of the fact that feature names often are crate names (and perhaps in the past that was the only form of feature?). However, now they are an entirely separate thing, and we should allow the same set of feature names that Cargo does. (As an aside, do we want to apply the same 64 character limit that we apply to crate names to feature names?) Fixes rust-lang#1329.
bors-voyager bot
added a commit
that referenced
this issue
Apr 9, 2018
1331: Allow feature names to begin with numbers r=carols10cents Diesel 1.2 had planned on renaming our `large-tables` and `huge-tables` features to `32-column-tables` and `64-column-tables` respectively, while also introducing the `128-column-tables` feature. This change was made several months ago in Diesel. Cargo will happily accept those as feature names, and resolve them properly from other crates. However while publishing Diesel 1.2, I ran into a snag mid-release when I realized that Cargo is incorrectly assuming that a feature name must be the same as a crate name. I suspect this is an artifact of the fact that feature names often are crate names (and perhaps in the past that was the only form of feature?). However, now they are an entirely separate thing, and we should allow the same set of feature names that Cargo does. (As an aside, do we want to apply the same 64 character limit that we apply to crate names to feature names?) Fixes #1329.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While releasing Diesel 1.2 crates.io blocked me from uploading one of the crates because it has an optional feature called
128-column-tables, which cargo accepts, but crates.io doesn't. We seem to be assuming that feature names always map to crates, which is not what happens in practice.The text was updated successfully, but these errors were encountered: