Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FixFeature2 background worker job #6169

Closed
wants to merge 1 commit into from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Mar 9, 2023

This job "fixes" the features2 entries by moving all features into feature2 if feature2 already has content. This should avoid a mismatch of features pointing to features2 for older cargo versions.

Related:

This job "fixes" the `features2` entries by moving all `features` into `feature2` if `feature2` already has content. This should avoid a mismatch of `features` pointing to `features2` for older cargo versions.
@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Mar 9, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 9, 2023

It looks like this would affect 2049 files in the index, which is an uncomfortably large number. It would be good to get some data on how long that will affect the index update, particularly with a cached copy that hasn't been updated in a while (like sometime between Jan 13 and Feb 1 to be after the normalization commit).

@bors
Copy link
Contributor

bors commented Apr 21, 2023

☔ The latest upstream changes (presumably #5066) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 4, 2024

#9551 has fixed the original issue, but our background worker code has evolved enough to not be useful to try to rebase this PR.

we'll keep running with the new feature splitting code for a while and may perform a batch update at a later point in time to reduce the number of git deltas needed for the update.

@Turbo87 Turbo87 closed this Oct 4, 2024
@Turbo87 Turbo87 deleted the features-normalize branch October 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants