Show README and metadata for yanked crates/versions #6415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
LawnGnome
approved these changes
May 2, 2023
app/components/crate-header.hbs
Outdated
Comment on lines
8
to
16
| <span local-class="yanked-badge"> | ||
| {{svg-jar "trash"}} | ||
| Yanked | ||
| </span> |
There was a problem hiding this comment.
Do we want to link to something — or at least have a tooltip — which explains what yanking means in the same way the previous version said "This crate has been yanked, but it is still available for download for other crates that may be depending on it"?
There was a problem hiding this comment.
that sounds like a good idea, thanks! 👍
Turbo87
force-pushed
the
yanked-version-display
branch
from
93b27c7
to
e8d6f9b
Compare
|
I've modified the existing tests for this route to cover the new behavior. This PR is ready for review/merging now. Unless there are any objections I plan on merging this some time tomorrow. |
LawnGnome
approved these changes
May 3, 2023
This was referenced May 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6414
Before
After
I'm opening this as a draft PR for discussion among the team. Also, tests are still missing for this change.