models/krate: Improve feature validation #7537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compared to the output of `assert!()` (`true != false`), these give a bit more context on the actual and expected values.
`valid` is a property name, which suggests that the fn returns a `bool`. If the fn returns a `Result` it's better to name the function like an action, e.g. `validate`.
The `models` module should ideally not know anything about the HTTP API layer and the `cargo_err()` fn.
Turbo87
added
C-internal 🔧
Rustin170506
approved these changes
Nov 16, 2023
| )] | ||
| Char(char, String), | ||
| #[error(transparent)] | ||
| DependencyName(#[from] InvalidDependencyName), |
There was a problem hiding this comment.
I'm uncertain about placing it here, as it is also used in validate_dependency. It's not intended for validating the feature name. But I can help to improve it in my next PR.
There was a problem hiding this comment.
InvalidDependencyName can also be used directly :)
There was a problem hiding this comment.
Oh. Got it. It's nice. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #7500 (review), I have a few suggestions on how the feature validation code can be improved :)