Skip to content

Commit

Permalink
extend comment on match_version semver match
Browse files Browse the repository at this point in the history
  • Loading branch information
syphar committed Sep 22, 2024
1 parent 6514a79 commit ffa296e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/web/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ fn semver_match<'a, F: Fn(&Release) -> bool>(
req: &VersionReq,
filter: F,
) -> Option<&'a Release> {
// first try standard semver match using `VersionReq::match`, should handle most cases.
if let Some(release) = releases
.iter()
.filter(|release| filter(release))
Expand All @@ -249,8 +250,9 @@ fn semver_match<'a, F: Fn(&Release) -> bool>(
Some(release)
} else if req == &VersionReq::STAR {
// semver `*` does not match pre-releases.
// When someone wants the latest release and we have only pre-releases
// just return the latest prerelease.
// So when we only have pre-releases, `VersionReq::STAR` would lead to an
// empty result.
// In this case we just return the latest latest prerelase instead of nothing.
return releases.iter().find(|release| filter(release));
} else {
None
Expand Down

0 comments on commit ffa296e

Please sign in to comment.