Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static resources corresponding to 20210305-1.52.0-nightly-caca2121f are missing #1305

Closed
dtolnay opened this issue Mar 6, 2021 · 11 comments
Closed

Comments

@dtolnay
Copy link
Member

dtolnay commented Mar 6, 2021

https://docs.rs/serde/1.0.123/serde/ looks fine, but https://docs.rs/serde/1.0.124/serde/ seems to fail to load a bunch of stuff.


Screenshot from 2021-03-05 20-01-26


Screenshot from 2021-03-05 20-01-47

@rkuhn
Copy link

rkuhn commented Mar 6, 2021

@Nemo157
Copy link
Member

Nemo157 commented Mar 6, 2021

I reproduced this on my local instance:

copying essential files for rustc 1.52.0-nightly (caca2121f 2021-03-05)
couldn't copy '/opt/docsrs/rustwide/builds/essential-files-20210305-1.52.0-nightly-caca2121f/target/doc/FireSans-Medium.woff2' to '/tmp/essential-fileskQqkWB/FireSans-Medium.woff2'

But then it goes on to build the next crate in the queue and because the nightly version hasn't changed it skips acquiring the essential files.

@syphar
Copy link
Member

syphar commented Mar 6, 2021

so it seems related to 5e5f407

@Nemo157
Copy link
Member

Nemo157 commented Mar 6, 2021

Yep, I'm not sure why though, rust-lang/rust#82545 was merged 8 days ago so the files should be there, unless this has been reverted in the meantime?

I'm going to try making a change so that if essential files fail we don't continue building crates so that the impact of failures like this won't be so bad, but once rust-lang/rust#82803 is merged and used this shouldn't reoccur.

Nemo157 added a commit to Nemo157/docs.rs that referenced this issue Mar 6, 2021
Reduces the impact from failures like rust-lang#1305, rather than continuing to
build crates with the failing toolchain we will just stop building
crates until an admin has time to investigate the cause.
@rkuhn
Copy link

rkuhn commented Mar 6, 2021

Thanks for quickly looking into this! However, it is not obvious to me what I need to do to get the docs fixed — please let me know.

@Nemo157
Copy link
Member

Nemo157 commented Mar 6, 2021

Nothing 😁, there's a bug fix we need to deploy, then we'll rebuild all affected documentation.

@rkuhn
Copy link

rkuhn commented Mar 6, 2021

Oh, cool! I thought I’d have to push a new version once the bug is fixed 🙂

@syphar
Copy link
Member

syphar commented Mar 6, 2021

For this specific thing I even assume we don't even need to rebuild the docs, because they are already referencing to the correctly hashed files.

@Nemo157
Copy link
Member

Nemo157 commented Mar 6, 2021

Ah yes, cratesfyi build add-essential-files should fix it.

@jyn514
Copy link
Member

jyn514 commented Mar 6, 2021

This has been fixed.

@jyn514 jyn514 closed this as completed Mar 6, 2021
@jyn514
Copy link
Member

jyn514 commented Mar 6, 2021

Yep, I'm not sure why though, rust-lang/rust#82545 was merged 8 days ago so the files should be there, unless this has been reverted in the meantime?

We didn't try to copy the files until yesterday: #1301. Last night was the first time docs.rs tried to run a build with the new toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants