Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left slider not working #417

Closed
liborty opened this issue Sep 30, 2019 · 6 comments
Closed

Left slider not working #417

liborty opened this issue Sep 30, 2019 · 6 comments
Assignees
@GuillaumeGomez

Comments

@liborty
Copy link

liborty commented Sep 30, 2019

Firefox 69.0.1, Linux x86-64.
Even when the left hand slider is put hard down, some of the docs menu items (functions, crates, etc) remain hidden and inaccessible.
Screenshot from 2019-10-01 09-30-17
@GuillaumeGomez
Copy link
Member

Sending a fix to rustdoc.

@GuillaumeGomez GuillaumeGomez self-assigned this Oct 1, 2019
This was referenced Oct 1, 2019
Merged
Closed
@liborty
Copy link
Author

liborty commented Oct 1, 2019

Thank you. I would not say it was such a small matter, as it made a lot of documentation inaccessible.

Centril added a commit to Centril/rust that referenced this issue Oct 2, 2019
@Centril
Rollup merge of rust-lang#64948 - GuillaumeGomez:improve-sidebar-styl…
1c8ef98 
…ing, r=Mark-Simulacrum

Improve sidebar styling to make its integration easier

Part of rust-lang/docs.rs#417

Setting the height was an error: forcing the element bottom to be at the bottom allows to change to top of the sidebar.

r? @Mark-Simulacrum
@GuillaumeGomez
Copy link
Member

It's fixed in rustdoc.

@pietroalbini @QuietMisdreavus Any idea if we could/should update the current noscript stylesheets to backport this change?

@pietroalbini
Copy link
Member

That's not trivial as we'd need to change the noscript stylesheets for each affected nightly.

@GuillaumeGomez
Copy link
Member

Indeed. :)

@jyn514
Copy link
Member

jyn514 commented Nov 14, 2019

Closing in favor of #464

@jyn514 jyn514 closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liborty @pietroalbini @GuillaumeGomez @jyn514